danny0405 commented on code in PR #18092:
URL: https://github.com/apache/hudi/pull/18092#discussion_r2796748679
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -122,7 +122,10 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean>
buildClusteringGroupsForP
* Return list of partition paths to be considered for clustering.
*/
public Pair<List<String>, List<String>>
filterPartitionPaths(HoodieWriteConfig writeConfig, List<String> partitions) {
- return ClusteringPlanPartitionFilter.filter(partitions, getWriteConfig());
+ Pair<List<String>, List<String>> result =
ClusteringPlanPartitionFilter.filter(partitions, getWriteConfig());
Review Comment:
> which can lead to non-deterministic behavior in clustering operations.
is it because the following up filtering like the file group numbers limits
in `#generateClusteringPlan`, we you think we should move the sorting into
where these limits takes place(like in `##generateClusteringPlan`)? do we also
got issues for compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
