yihua commented on code in PR #18187:
URL: https://github.com/apache/hudi/pull/18187#discussion_r2801774163
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1419,7 +1419,10 @@ public void
validateAgainstTableProperties(HoodieTableConfig tableConfig, Hoodie
}
if (!keyGenClass.equals("org.apache.hudi.keygen.SimpleKeyGenerator")
&&
!keyGenClass.equals("org.apache.hudi.keygen.NonpartitionedKeyGenerator")
- &&
!keyGenClass.equals("org.apache.hudi.keygen.ComplexKeyGenerator")) {
+ && !keyGenClass.equals("org.apache.hudi.keygen.ComplexKeyGenerator")
+ &&
!keyGenClass.equals("org.apache.hudi.keygen.SimpleAvroKeyGenerator")
+ &&
!keyGenClass.equals("org.apache.hudi.keygen.NonpartitionedAvroKeyGenerator")
+ &&
!keyGenClass.equals("org.apache.hudi.keygen.ComplexAvroKeyGenerator")) {
Review Comment:
Could you also add a test for the case you mentioned to cover this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
