yihua commented on code in PR #17877:
URL: https://github.com/apache/hudi/pull/17877#discussion_r2802809279
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/BaseTestKafkaSource.java:
##########
@@ -323,28 +325,14 @@ public void testKafkaSourceWithOffsetsFromSourceProfile()
{
verify(metrics,
times(2)).updateStreamerSourceBytesToBeIngestedInSyncRound(Long.MAX_VALUE);
}
+ @AllArgsConstructor
+ @Getter
static class TestSourceProfile implements SourceProfile<Long> {
private final long maxSourceBytes;
private final int sourcePartitions;
private final long numEvents;
Review Comment:
Should this be marked as `@Getter(AccessLevel.NONE)`?
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -1447,14 +1423,14 @@ public boolean validate(long tableTotalRecords, long
tableTotalErroredRecords, O
if (canProceed) {
return canProceed;
} else {
- LOG.error("Delta Sync found errors when writing. Errors/Total=" +
totalErroredRecords + "/" + totalRecords);
- LOG.error("Printing out the top 100 errors");
+ log.error("Delta Sync found errors when writing. Errors/Total={}/{}",
totalErroredRecords, totalRecords);
+ log.error("Printing out the top 100 errors");
ValidationUtils.checkArgument(writeStatusesOpt.isPresent(), "RDD
<WriteStatus> is expected to be present when there are errors ");
HoodieJavaRDD.getJavaRDD(writeStatusesOpt.get()).filter(WriteStatus::hasErrors).take(100).forEach(writeStatus
-> {
- LOG.error("Global error " + writeStatus.getGlobalError());
+ log.error("Global error {}",
String.valueOf(writeStatus.getGlobalError()));
if (!writeStatus.getErrors().isEmpty()) {
writeStatus.getErrors().forEach((k,v) -> {
- LOG.trace("Error for key %s : %s ", k, v);
+ log.trace("Error for key %s : %s ", k, v);
Review Comment:
This line still uses `%s` placeholders instead of `{}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
