cshuo opened a new pull request, #18206:
URL: https://github.com/apache/hudi/pull/18206
### Describe the issue this Pull Request addresses
This PR solves two problems:
1) When CDC is enabled for flink ingestion, the cdc reader needs the base
file metadata to have deterministic update sequence, e.g., setting `prevCommit`
properly in the write stat, so async blocking generation should be disabled for
this scenario.
2) When eager flushing happens for MOR ingestion, there would be multiple
write stats with same instant, such case should be covered in
`HoodieCDCFileSplit#compareTo`.
### Summary and Changelog
- Updated OptionsResolver.isBlockingInstantGeneration:
- Enables blocking instant generation for MOR + CDC upserts as well.
- Enhanced HoodieCDCFileSplit.compareTo:
- When instants are equal and inference case is LOG_FILE, use
beforeFileSlice log-file count as a tie-breaker to preserve deterministic
ordering for splits in the same instant.
### Impact
Improves determinism of write/commit ordering for Flink CDC, especially MOR
+ upsert.
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
low
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
