nsivabalan commented on a change in pull request #2451:
URL: https://github.com/apache/hudi/pull/2451#discussion_r558919944
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java
##########
@@ -177,10 +179,12 @@ public HoodieMetadataPayload
preCombine(HoodieMetadataPayload previousRecord) {
/**
* Returns the files added as part of this record.
*/
- public FileStatus[] getFileStatuses(Path partitionPath) {
+ public FileStatus[] getFileStatuses(Configuration hadoopConf, Path
partitionPath) throws IOException {
+ FileSystem fs = partitionPath.getFileSystem(hadoopConf);
+ long blockSize = fs.getDefaultBlockSize(partitionPath);
return filterFileInfoEntries(false)
- .map(e -> new FileStatus(e.getValue().getSize(), false, 0, 0, 0, 0,
null, null, null,
- new Path(partitionPath, e.getKey())))
+ .map(e -> new FileStatus(e.getValue().getSize(), false, 0, blockSize,
0, 0,
Review comment:
I don't know the entire flow. but wondering why not set every arg in new
FileStatus(....) from e.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
