xushiyan commented on code in PR #18212:
URL: https://github.com/apache/hudi/pull/18212#discussion_r2830965160
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/function/HoodieSplitReaderFunction.java:
##########
@@ -112,18 +123,28 @@ private HoodieFileGroupReader<RowData>
createFileGroupReader(HoodieSourceSplit s
).orElse(Collections.emptyList())
);
- FlinkReaderContextFactory readerContextFactory = new
FlinkReaderContextFactory(metaClient);
+ final FlinkRowDataReaderContext readerContext =
+ new FlinkRowDataReaderContext(
+ metaClient.getStorageConf(),
+ () ->
InternalSchemaManager.get(metaClient.getStorageConf(), metaClient),
+ predicates,
+ metaClient.getTableConfig(),
+ Option.empty());
+
+ HoodieWriteConfig writeConfig =
FlinkWriteClients.getHoodieClientConfig(configuration);
Review Comment:
this config object can be created once in constructor? since config should
be immutable anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
