suryaprasanna commented on code in PR #18196: URL: https://github.com/apache/hudi/pull/18196#discussion_r2831250986
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ########## Review Comment: @nsivabalan Auto commit is still executed in following three flows out of them SparkAutoCommitExecutor still needs the isCompleted. All these flows commit the data and would go through the current flow. http://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/bootstrap/SparkBootstrapCommitActionExecutor.java#L178 https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkAutoCommitExecutor.java#L39 https://github.com/apache/hudi/blob/master/hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkAutoCommitActionExecutor.java#L39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
