voonhous commented on code in PR #17771:
URL: https://github.com/apache/hudi/pull/17771#discussion_r2838236337
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestAvroSchemaResolutionSupport.scala:
##########
@@ -120,26 +120,25 @@ class TestAvroSchemaResolutionSupport extends
HoodieClientTestBase with ScalaAss
// convert int to string first before conversion to binary
val initDF = prepDataFrame(df1, colInitType)
initDF.printSchema()
- initDF.show(false)
+ initDF.collect
// recreate table
initialiseTable(initDF, tempRecordPath, tableType)
// perform avro supported casting
var upsertDf = prepDataFrame(df2, colInitType)
upsertDf = castColToX(a, colToCast, upsertDf)
- upsertDf.printSchema()
- upsertDf.show(false)
+ upsertDf.schema.toString()
Review Comment:
Is there a reason for `upsertDf.schema.toString()`? it's not doing anything
here iiuc.
##########
hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestClosableSortedDedupingIterator.java:
##########
@@ -34,6 +36,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
public class TestClosableSortedDedupingIterator {
+ private static final Logger LOG =
LoggerFactory.getLogger(TestClosableSortedDedupingIterator.class);
Review Comment:
Let's use Lombok for this?
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/io/storage/TestHoodieNativeAvroHFileReaderCaching.java:
##########
@@ -60,6 +62,7 @@
import static org.mockito.Mockito.when;
public class TestHoodieNativeAvroHFileReaderCaching {
+ private static final Logger LOG =
LoggerFactory.getLogger(TestHoodieNativeAvroHFileReaderCaching.class);
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
