xushiyan commented on code in PR #18212:
URL: https://github.com/apache/hudi/pull/18212#discussion_r2838521482
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/InstantRange.java:
##########
@@ -273,4 +273,18 @@ public InstantRange build() {
}
}
}
+
+ public static RangeType getRangeType(InstantRange range) {
Review Comment:
if any new subclass added for InstantRange, this would silently break and
need maintenance. I'd make getRangeType an abstract method and let each
subclass implements it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
