suryaprasanna commented on code in PR #17850:
URL: https://github.com/apache/hudi/pull/17850#discussion_r2842703007
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -477,6 +477,12 @@ abstract class HoodieBaseRelation(val sqlContext:
SQLContext,
getPartitionColumnsAsInternalRowInternal(file,
metaClient.getBasePath, extractPartitionValuesFromPartitionPath = true)
+ protected def usePartitionValueExtractorOnRead(optParams: Map[String,
String], sparkSession: SparkSession): Boolean = {
+
optParams.getOrElse(DataSourceReadOptions.USE_PARTITION_VALUE_EXTRACTOR_ON_READ.key,
+
DataSourceReadOptions.USE_PARTITION_VALUE_EXTRACTOR_ON_READ.defaultValue).toBoolean
||
+ ProvidesHoodieConfig.isSchemaEvolutionEnabled(sparkSession)
Review Comment:
I dont think schema evolution enabled check is needed here, removing this.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -657,6 +658,13 @@ public class FlinkOptions extends HoodieConfig {
+ "**Note** This is being actively worked on. Please use "
+ "`hoodie.datasource.write.keygenerator.class` instead.");
+ @AdvancedConfig
+ public static final ConfigOption<String> PARTITION_VALUE_EXTRACTOR =
ConfigOptions
+ .key(HoodieSyncConfig.META_SYNC_PARTITION_EXTRACTOR_CLASS.key())
Review Comment:
Sure, making the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
