nsivabalan commented on code in PR #18106:
URL: https://github.com/apache/hudi/pull/18106#discussion_r2850758129
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestFileGroupReaderSchemaHandler.java:
##########
@@ -276,4 +282,45 @@ public void testSchemaForMandatoryFields(boolean
setPrecombine,
HoodieSchema actualSchema =
fileGroupReaderSchemaHandler.generateRequiredSchema(deleteContext);
assertEquals(expectedSchema, actualSchema);
}
+
+ /**
+ * Tests that for a pre-v9 table (e.g., version 6) where
getRecordMergeMode() returns null
+ * (because the property didn't exist), but the payload class is a custom one
+ * (like HoodieMetadataPayload), generateRequiredSchema correctly infers
CUSTOM merge mode
+ * and returns the full table schema when the merger is not projection
compatible.
+ */
+ @Test
+ public void
testGenerateRequiredSchemaPreV9CustomPayloadInfersCustomMergeMode() {
Review Comment:
do we have tests for preV9, but resolving to COMMIT_TIME merge mode and
EVENT_TIME merge mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
