suryaprasanna commented on code in PR #18136:
URL: https://github.com/apache/hudi/pull/18136#discussion_r2850991474


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -527,6 +527,21 @@ object HoodieFileIndex extends Logging {
       
properties.setProperty(DataSourceReadOptions.FILE_INDEX_LISTING_MODE_OVERRIDE.key,
 listingModeOverride)
     }
 
+    var pathFilterOptimizedListingEnabled = getConfigValue(options, sqlConf,
+      
DataSourceReadOptions.FILE_INDEX_LIST_FILE_STATUSES_USING_RO_PATH_FILTER.key, 
null)
+    if (pathFilterOptimizedListingEnabled != null) {
+      
properties.setProperty(DataSourceReadOptions.FILE_INDEX_LIST_FILE_STATUSES_USING_RO_PATH_FILTER.key,
+        pathFilterOptimizedListingEnabled)
+    } else {
+      // Also allow passing in the path filter config via Spark session conf 
for convenience
+      pathFilterOptimizedListingEnabled = getConfigValue(options, sqlConf,
+        "spark." + 
DataSourceReadOptions.FILE_INDEX_LIST_FILE_STATUSES_USING_RO_PATH_FILTER.key, 
null)

Review Comment:
   Yes, we also need to clean other configs as well. Let me take that as a 
followup. I would like to get this landed soon so the other PRs can be 
unblocked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to