yanghua edited a comment on pull request #2458:
URL: https://github.com/apache/hudi/pull/2458#issuecomment-762902669


   > I get where you are coming from. But I find Router kind of confusing. Its 
typical to name such classes that take all requests as handlers right? May be 
just FileSystemViewRequestHandler? I suggest we not remove FileSystemView part 
of the name. Its a core abstraction and good to preserve that connection. Wdyt?
   
   Perhaps different understandings depend on what we think this class will 
assume in the future and the boundaries of services. I want to change its name 
because it seems to be easily confused with `BaseFileHandler`. People who don't 
know the details will think that they are the same type of handler, but it is 
not.
   
   This module used to provide web services or RESTful API for timeline. It has 
many handlers (more in the future?) and one handler-registry(URI mapping, or 
say router)which is easy to understand?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to