nsivabalan commented on code in PR #17777:
URL: https://github.com/apache/hudi/pull/17777#discussion_r2873930844
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieStreamerConfig.java:
##########
@@ -139,4 +139,12 @@ public class HoodieStreamerConfig extends HoodieConfig {
.markAdvanced()
.sinceVersion("0.15.0")
.withDocumentation("When enabled, the dataframe generated from reading
source data is wrapped with an exception handler to explicitly surface
exceptions.");
+
+ public static final ConfigProperty<Boolean> TRANSFORMED_ROW_NULLABLE =
ConfigProperty
+ .key(STREAMER_CONFIG_PREFIX + "transformed.row.nullable")
Review Comment:
whats the expectation for existing schema?
say, we have an existing table w/ colA, colB and colC. and colC is not
nullable.
and user enables this config after few commits.
will this take effect only for new additions in schema?
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieStreamerConfig.java:
##########
@@ -139,4 +139,12 @@ public class HoodieStreamerConfig extends HoodieConfig {
.markAdvanced()
.sinceVersion("0.15.0")
.withDocumentation("When enabled, the dataframe generated from reading
source data is wrapped with an exception handler to explicitly surface
exceptions.");
+
+ public static final ConfigProperty<Boolean> TRANSFORMED_ROW_NULLABLE =
ConfigProperty
+ .key(STREAMER_CONFIG_PREFIX + "transformed.row.nullable")
Review Comment:
Also, can we add a test to mimic this scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
