danny0405 commented on code in PR #18254:
URL: https://github.com/apache/hudi/pull/18254#discussion_r2876137403
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/EventBuffers.java:
##########
@@ -143,9 +148,17 @@ public void awaitAllInstantsToCompleteIfNecessary() {
}
}
+ public void awaitPrevInstantsToComplete(long checkpointId) {
+ List<String> pendingInstants = getPendingInstantsBefore(checkpointId);
+ if (!pendingInstants.isEmpty() &&
this.indexBootstrapGuardOption.isPresent()) {
+ this.indexBootstrapGuardOption.get().blockFor(String.join(",",
pendingInstants));
+ }
+ }
+
public void reset(long checkpointId) {
this.eventBuffers.remove(checkpointId);
this.commitGuardOption.ifPresent(CommitGuard::unblock);
+ this.indexBootstrapGuardOption.ifPresent(CommitGuard::unblock);
Review Comment:
the unblock is conditional, we need to check all the `checkpointId` smaller
than the recovered id been committed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
