rahil-c commented on code in PR #18190:
URL: https://github.com/apache/hudi/pull/18190#discussion_r2893372911
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -79,6 +80,33 @@ object HoodieSparkSchemaConverters {
HoodieSchema.createDecimal(name, nameSpace, null, d.precision,
d.scale, fixedSize)
// Complex types
+ case ArrayType(elementSparkType, containsNull)
+ if metadata.contains(HoodieSchema.TYPE_METADATA_FIELD) &&
+
metadata.getString(HoodieSchema.TYPE_METADATA_FIELD).startsWith("VECTOR") =>
+ if (containsNull) {
+ throw new HoodieSchemaException(
+ s"VECTOR type does not support nullable elements (field:
$recordName)")
+ }
+
+ val vectorSchema = HoodieSchema
+
.parseTypeString(metadata.getString(HoodieSchema.TYPE_METADATA_FIELD))
+ .asInstanceOf[HoodieSchema.Vector]
+ val dimension = vectorSchema.getDimension
+ if (dimension <= 0) {
+ throw new HoodieSchemaException(
+ s"VECTOR dimension must be positive, got: $dimension (field:
$recordName)")
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
