HuangZhenQiu commented on code in PR #18287:
URL: https://github.com/apache/hudi/pull/18287#discussion_r2893609863
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/enumerator/AbstractHoodieSplitEnumerator.java:
##########
@@ -160,7 +160,6 @@ private void assignSplits() {
if (shouldWaitForMoreSplits()) {
// for continuous split provider callback
registerCallbackFromSplitProvider();
- break;
Review Comment:
Takes me a good amount of time to find the bug. We have a predefined split
assignment logic when splits are discovered before the loop. For example, we
have last split assigned task Id 2. If we break here for task Id 1, the split
will be never be assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
