kbuci commented on code in PR #18280:
URL: https://github.com/apache/hudi/pull/18280#discussion_r2897234452
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/PreferWriterConflictResolutionStrategy.java:
##########
@@ -51,10 +55,16 @@ public class PreferWriterConflictResolutionStrategy
@Override
public Stream<HoodieInstant> getCandidateInstants(HoodieTableMetaClient
metaClient, HoodieInstant currentInstant,
Option<HoodieInstant>
lastSuccessfulInstant) {
+ return getCandidateInstants(metaClient, currentInstant,
lastSuccessfulInstant, Option.empty());
+ }
+
+ @Override
+ public Stream<HoodieInstant> getCandidateInstants(HoodieTableMetaClient
metaClient, HoodieInstant currentInstant,
Review Comment:
Ideally I would refactor this API to require write config being passed or
create a constructor that takes write config. But since this is a public API I
didn't want to break it in between minor versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
