shangxinli commented on code in PR #18127:
URL: https://github.com/apache/hudi/pull/18127#discussion_r2899774011
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -622,6 +622,7 @@ private void doCommit(long checkpointId, String instant,
List<WriteStatus> dataW
// commit and error logging
HashMap<String, String> checkpointCommitMetadata = new HashMap<>();
StreamerUtil.addFlinkCheckpointIdIntoMetaData(conf,
checkpointCommitMetadata, checkpointId);
+ StreamerUtil.addKafkaOffsetMetaData(conf, checkpointCommitMetadata,
checkpointId, null);
Review Comment:
Good point. Added an overloaded addKafkaOffsetMetaData without the
FlinkCheckpointClient parameter for production use. The
collectKafkaOffsetCheckpoint method that accepts a client is now marked
@VisibleForTesting since it's only needed for injecting mock clients in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
