pratyakshsharma commented on code in PR #18310: URL: https://github.com/apache/hudi/pull/18310#discussion_r2923218928
########## README.md: ########## @@ -177,6 +177,9 @@ Refer to the table below for building with different Flink and Scala versions. For example, ``` +# Build against Flink 2.1.x +mvn clean package -DskipTests -Dflink2.1 Review Comment: Actually an example with flink 1.17 is given below. So this new addition is not really needed ########## README.md: ########## @@ -101,7 +101,7 @@ Prerequisites for building Apache Hudi: ``` # Checkout code and build git clone https://github.com/apache/hudi.git && cd hudi -mvn clean package -DskipTests +mvn clean package -DskipTests -Dspark3.5 -Dflink2.1 Review Comment: ```suggestion mvn clean package -DskipTests -Dspark3.5 -Dflink1.20 ``` Let us mention the default flink profile here ########## README.md: ########## @@ -177,6 +177,9 @@ Refer to the table below for building with different Flink and Scala versions. For example, ``` +# Build against Flink 2.1.x +mvn clean package -DskipTests -Dflink2.1 Review Comment: Lets mention spark profile as well, otherwise build will fail ########## README.md: ########## @@ -101,7 +101,7 @@ Prerequisites for building Apache Hudi: ``` # Checkout code and build git clone https://github.com/apache/hudi.git && cd hudi -mvn clean package -DskipTests +mvn clean package -DskipTests -Dspark3.5 -Dflink2.1 Review Comment: We should explicitly mention that users need to provide spark and flink profiles for build to succeed along with giving examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
