voonhous commented on code in PR #17833:
URL: https://github.com/apache/hudi/pull/17833#discussion_r2929806431


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/execution/datasources/SparkSchemaTransformUtils.scala:
##########
@@ -370,35 +371,43 @@ object SparkSchemaTransformUtils {
    * @param fileType Type from file schema
    * @return true if types are compatible for reading
    */
-  private def isDataTypeEqual(requiredType: DataType, fileType: DataType): 
Boolean = (requiredType, fileType) match {
-    case (requiredType, fileType) if requiredType == fileType => true
+  def isDataTypeEqual(requiredType: DataType, fileType: DataType): Boolean = {

Review Comment:
   This was added, which is why everything is shifted rightwards by 1 indent.
   
   ```
   val adapterResult = 
HoodieSparkUtils.sparkAdapter.isDataTypeEqualForPhysicalSchema(requiredType, 
fileType)
       if (adapterResult.isDefined) {
         adapterResult.get
       } else {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to