danny0405 commented on code in PR #18319:
URL: https://github.com/apache/hudi/pull/18319#discussion_r2937982820
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -707,6 +707,13 @@ public class FlinkOptions extends HoodieConfig {
.withDescription("Maximum memory in MB for a write task, when the
threshold hits,\n"
+ "it flushes the max size data bucket to avoid OOM, default 1GB");
+ @AdvancedConfig
+ public static final ConfigOption<Boolean>
WRITE_BUFFER_MANAGED_MEMORY_ENABLED = ConfigOptions
+ .key("write.buffer.managed.memory.enabled")
Review Comment:
should we use some enum to unify the options:
`write.buffer.type`
- 1. ON-HEAP
- 2. MANAGED(OFF-HEAP)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
