nsivabalan commented on code in PR #18181:
URL: https://github.com/apache/hudi/pull/18181#discussion_r2943005267
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/TestHoodieTable.java:
##########
@@ -136,4 +138,54 @@ void testRollbackInflightInstant() throws IOException {
// Validate that function scheduleRollback is called.
assertEquals(1, ((TestBaseHoodieTable)
hoodieTable).getCountOfScheduleRollbackFunctionCalls());
}
+
+ @Test
+ void testMaybeDeleteMetadataTableSkipsWhenAutoDeleteDisabled() throws
IOException {
Review Comment:
and also validate that col stats did receive a log file as well (from
HoodieCommitMetadata).
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/TestHoodieTable.java:
##########
@@ -136,4 +138,54 @@ void testRollbackInflightInstant() throws IOException {
// Validate that function scheduleRollback is called.
assertEquals(1, ((TestBaseHoodieTable)
hoodieTable).getCountOfScheduleRollbackFunctionCalls());
}
+
+ @Test
+ void testMaybeDeleteMetadataTableSkipsWhenAutoDeleteDisabled() throws
IOException {
Review Comment:
can we add one end to end functional test to validate that, after
initializing, if mdt config had disable col stats, but w/ "auto delete
partitions' config as false. we validate that, col stats is not deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
