prashantwason commented on PR #18179: URL: https://github.com/apache/hudi/pull/18179#issuecomment-4084402786
@nsivabalan All review comments have been addressed: 1. **DistributedRegistry initialization** — Explained the flow via `HoodieSparkEngineContext.getMetricRegistry()` → `DistributedRegistry.register(javaSparkContext)`. 2. **`::` delimiter parsing** — Updated to use `lastIndexOf` instead of `indexOf` (commit 8544d31) to handle edge cases where table names might contain `::`. 3. **DISTRIBUTED_REGISTRY_MAP cleanup** — Entries are bounded (2 per table), memory footprint is negligible. Can add `removeMetricRegistry()` in a follow-up if needed. CI is green. Could you take another look when you get a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
