prashantwason commented on PR #18251: URL: https://github.com/apache/hudi/pull/18251#issuecomment-4084556941
@nsivabalan All review comments from the second round have been addressed (commit 7316de5): 1. **DELTA_COMMIT support** — Added `DELTA_COMMIT_ACTION` handling so MOR table delta commits are now processed. 2. **Log file handling** — Rewrote file slice construction to group write stats by fileId and handle both base files and log files using `FSUtils.isLogFile()`. 3. **Sizing: base files only** — Reverted `getTotalFileSize()` to only count base file sizes, as log files typically contain updates and should not inflate size estimates. 4. **MOR tests** — Added `testGenerateClusteringPlanWithDeltaCommit` and `testGenerateClusteringPlanWithMixedCommitAndDeltaCommit`. 5. **File slice sorting** — File slices are now sorted by base file size in descending order before grouping. CI was green on the previous commit. Could you take another look when you get a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
