prashantwason commented on PR #18083: URL: https://github.com/apache/hudi/pull/18083#issuecomment-4084726100
@cshuo All review comments have been addressed: 1. **Sort key resolution**: Now uses `AppendWriteFunctions.resolveSortKeys()` which falls back to record key when `write.buffer.sort.keys` is not set 2. **Object reuse safety**: Added `RowDataSerializer.copy()` when Flink object reuse is enabled to prevent TreeMap ordering corruption 3. **Local variable**: Made `reusableKeyBuffer` a local variable in `open()` 4. **endInput cleanup**: Moved `sortedRecords.clear()` and `insertionSequence = 0L` inside the `if` branch 5. **snapshotState cleanup**: Same as above 6. **Stale class name**: Fixed javadoc reference to `AppendWriteFunctionWithBIMBufferSort` 7. **Config migration**: Removed `WRITE_BUFFER_SORT_CONTINUOUS_ENABLED`, now uses `WRITE_BUFFER_TYPE=CONTINUOUS_SORT` via `BufferType` enum. Updated `AppendWriteFunctions.create()` routing and tests. Please take another look when you get a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
