yihua commented on code in PR #18227:
URL: https://github.com/apache/hudi/pull/18227#discussion_r2957140691
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/JDBCBasedMetadataOperator.java:
##########
@@ -182,12 +179,16 @@ public String getTableLocation(String tableName) {
* <p>Note: partition locations are not available from
* {@code SHOW PARTITIONS}. The returned {@link Partition} objects
* have locations constructed from the table base path.
+ *
+ * <p>Example: {@code SHOW PARTITIONS} returns rows like
+ * {@code datestamp=2025-01-15/region=us}, which is parsed into a
+ * {@link Partition} with values {@code ["2025-01-15", "us"]} and
+ * location {@code basePath/datestamp=2025-01-15/region=us}.
Review Comment:
Does this assume that the partition path uses the Hive-style partitioning
(`column=value`) and does `partSpec` reflect the actual relative partition path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
