rahil-c commented on code in PR #18347: URL: https://github.com/apache/hudi/pull/18347#discussion_r2965552849
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/types/BlobType.scala: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.types + +import org.apache.hudi.common.schema.HoodieSchema + +import org.apache.spark.sql.avro.HoodieSparkSchemaConverters + +/** + * Factory object for creating Spark StructType representation of {@link HoodieSchema.Blob}. + * + * BLOB is a logical type in Hudi that represents binary large objects. The data can be + * stored inline (as bytes) or out-of-line (as a reference to a file location). + */ +object BlobType { + + /** + * Creates a StructType representing a {@link HoodieSchema.Blob}. + * + * @return StructType with blob structure + */ + def apply(): DataType = { + HoodieSparkSchemaConverters.toSqlType(HoodieSchema.createBlob())._1 Review Comment: [nit] During sql parsing `visitPrimitiveDataType` would always be invoked and call this later. I think we might want to cache the call at L40, maybe something like this? ``` object BlobType { val dataType: DataType = HoodieSparkSchemaConverters.toSqlType(HoodieSchema.createBlob())._1 def apply(): DataType = dataType } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
