xushiyan commented on code in PR #18325:
URL: https://github.com/apache/hudi/pull/18325#discussion_r2969046538
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/split/HoodieSourceSplit.java:
##########
@@ -38,7 +37,6 @@
*/
@Getter
@EqualsAndHashCode
-@ToString
Review Comment:
hmmm ok this indicates there is a code smell where splitId() coupled with
toString(). Could we decouple them into like `return splitNum + ":" + fileId;`
for splitId() ?
in any case, you can still do this in lombok
```java
@ToString(exclude = {"fileOffset", "consumed"})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
