xushiyan commented on code in PR #18325:
URL: https://github.com/apache/hudi/pull/18325#discussion_r2969235210
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/HoodieSourceSplitReader.java:
##########
@@ -43,42 +44,59 @@
/**
* The split reader of Hoodie source.
*
+ * <p>Each call to {@link #fetch()} reads one split and returns it as a single
+ * {@link RecordsWithSplitIds} batch. Flink's {@code SourceReaderBase} is
responsible for
+ * draining all records from the batch (via {@code nextRecordFromSplit()}) and
marking
+ * the split finished (via {@code finishedSplits()}) before calling {@link
#fetch()} again.
+ *
* @param <T> record type
*/
public class HoodieSourceSplitReader<T> implements
SplitReader<HoodieRecordWithPosition<T>, HoodieSourceSplit> {
private static final Logger LOG =
LoggerFactory.getLogger(HoodieSourceSplitReader.class);
private final SerializableComparator<HoodieSourceSplit> splitComparator;
- private final SplitReaderFunction<T> readerFunction;
private final Queue<HoodieSourceSplit> splits;
- private final SourceReaderContext context;
private final FlinkStreamReadMetrics readerMetrics;
-
- private HoodieSourceSplit currentSplit;
+ private final BatchReader batchReader;
Review Comment:
need to declare type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
