suryaprasanna commented on code in PR #17943:
URL: https://github.com/apache/hudi/pull/17943#discussion_r2971144885


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -154,12 +156,37 @@ public List<String> 
getPartitionPathsToClean(Option<HoodieInstant> earliestRetai
       case KEEP_LATEST_BY_HOURS:
         return getPartitionPathsForCleanByCommits(earliestRetainedInstant);
       case KEEP_LATEST_FILE_VERSIONS:
+        if (canCleanBeSkipped()) {

Review Comment:
   @nsivabalan Idea is to handle for KEEP_LATEST_FILE_VERSIONS only. Not sure 
how it will work for KEEP_LATEST_BY_HOURS and others. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to