yunchipang commented on code in PR #566:
URL: https://github.com/apache/hudi-rs/pull/566#discussion_r2978512420
##########
crates/core/src/expr/filter.rs:
##########
@@ -31,6 +32,30 @@ pub struct Filter {
pub field_name: String,
pub operator: ExprOperator,
pub field_value: String,
+ /// For IN/NOT IN operators only. Empty for other operators.
+ pub field_values: Vec<String>,
+}
+
+impl Filter {
+ /// Create a filter with a single value (for =, !=, <, <=, >, >=)
+ pub fn new_single(field_name: String, operator: ExprOperator, field_value:
String) -> Self {
Review Comment:
Used dual-field approach (keeping `field_value` + adding `field_values`)
with `new_single()`/`new_multi()` constructors to minimize ripple changes. This
avoids updating every existing `Filter` instantiation. not sure if there's a
better approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
