danny0405 commented on code in PR #18295:
URL: https://github.com/apache/hudi/pull/18295#discussion_r2985325131


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -362,6 +410,62 @@ public static HoodieWriteConfig createMetadataWriteConfig(
     return metadataWriteConfig;
   }
 
+  /**
+   * Build a {@link HoodieLockConfig} for the metadata table by copying 
lock-related configs
+   * from the data table's write config based on the configured lock provider.
+   * Only built-in lock providers are supported.
+   */
+  @VisibleForTesting
+  static HoodieLockConfig buildMdtLockConfig(String lockProviderClass, 
HoodieWriteConfig writeConfig) {

Review Comment:
   does it makes sense we move this util into `HoodieLockConfig`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to