prashantwason commented on PR #18083: URL: https://github.com/apache/hudi/pull/18083#issuecomment-4123329639
@cshuo All review comments from the latest round have been addressed in commit e5921668: 1. **`super.snapshotState()` / `super.endInput()` out of `finally`**: Moved both out of `finally` clauses to match other append write functions — write meta event is no longer sent to coordinator when there is an ingestion exception. 2. **`isObjectReuseEnabled()` compilation on Flink 1.17/1.18**: Changed to `getRuntimeContext().getExecutionConfig().isObjectReuseEnabled()` for compatibility with lower Flink versions. 3. **MemorySegment allocation in TreeMap comparator**: Pre-wrapped `MemorySegment` is now stored in `SortKey.keySegment` to avoid per-comparison allocation and reduce GC pressure. 4. **Test with object reuse enabled**: Added `testObjectReuseEnabled` test that verifies records are correctly copied when Flink object reuse is enabled (prevents TreeMap corruption from mutated references). Please take another look when you get a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
