xushiyan commented on code in PR #570:
URL: https://github.com/apache/hudi-rs/pull/570#discussion_r3013099669
##########
crates/core/src/config/table.rs:
##########
@@ -221,6 +217,19 @@ impl ConfigParser for HudiTableConfig {
.map(|v| v.as_str())
.ok_or(NotFound(self.key()));
+ // For PrecombineField, also check hoodie.table.ordering.fields (Hudi
1.x
+ // renamed precombine.field to ordering.fields; the old key is an
alternative).
+ let get_result = if matches!(self, Self::PrecombineField) {
+ get_result.or_else(|_| {
+ configs
+ .get("hoodie.table.ordering.fields")
Review Comment:
we need to add a new enum item called `OrderingFields` as a table config,
and mark `PrecombineField` as deprecated. Then all applicable callers resolve
ordering fields first then fall back to precombine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
