kbuci commented on code in PR #18295:
URL: https://github.com/apache/hudi/pull/18295#discussion_r3013581160
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java:
##########
@@ -241,6 +248,16 @@ public class HoodieLockConfig extends HoodieConfig {
@Deprecated
public static final String LOCK_PROVIDER_CLASS_PROP =
LOCK_PROVIDER_CLASS_NAME.key();
+ // Lock provider class names from modules not directly accessible in
hudi-client-common.
Review Comment:
Won't we still need this change so that we can create a MDT write client
that will implicitly take data table lock when calling `compact` APIs? Since
although in the data table write client we can construct a MDT write client and
call `compact` on it, afaik it would just perform all the execution/completion
steps with single_writer mode. Is there a way to work around this?
@nsivabalan what are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
