zhaoyudi-creator commented on code in PR #18437:
URL: https://github.com/apache/hudi/pull/18437#discussion_r3021875640
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ArchiveCommitsProcedure.scala:
##########
@@ -36,7 +38,9 @@ class ArchiveCommitsProcedure extends BaseProcedure
ProcedureParameter.optional(2, "min_commits", DataTypes.IntegerType, 20),
ProcedureParameter.optional(3, "max_commits", DataTypes.IntegerType, 30),
ProcedureParameter.optional(4, "retain_commits", DataTypes.IntegerType,
10),
- ProcedureParameter.optional(5, "enable_metadata", DataTypes.BooleanType,
true)
+ ProcedureParameter.optional(5, "enable_metadata", DataTypes.BooleanType,
false),
Review Comment:
The default value for 'enable_metadata' should not be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
