n3nash commented on a change in pull request #2496:
URL: https://github.com/apache/hudi/pull/2496#discussion_r565104712
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/fs/HoodieWrapperFileSystem.java
##########
@@ -79,8 +81,10 @@ public static void setMetricsRegistry(Registry registry,
Registry registryMeta)
METRICS_REGISTRY_META = registryMeta;
}
+ public static final int MIN_IO_BUFFER_SIZE = 1 * 1024 * 1024; // 1 MB
Review comment:
Can you add javadocs on why we need 2 different buffer sizes here ?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/fs/HoodieWrapperFileSystem.java
##########
@@ -90,11 +94,18 @@ public static void setMetricsRegistry(Registry registry,
Registry registryMeta)
R get() throws IOException;
}
+ @FunctionalInterface
+ public interface CheckedIntFunction extends CheckedFunction<Integer> {
Review comment:
What is this used for ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
