mailtoboggavarapu-coder opened a new pull request, #18457:
URL: https://github.com/apache/hudi/pull/18457
### Describe the issue this Pull Request addresses
### What changes were proposed in this pull request?
Fixed a resource leak in `HiveIncrementalPuller.executeIncrementalSQL()`
where a `java.util.Scanner` object opened on a file was never closed.
**Before (buggy):**
```java
String incrementalSQL = new Scanner(new
File(config.incrementalSQLFile)).useDelimiter("\\Z").next();
```
The `Scanner` was constructed inline, used immediately, and never explicitly
closed. Every call to `executeIncrementalSQL` would open a file handle that the
JVM would only reclaim at GC time, potentially exhausting OS file descriptors
under sustained load.
**After (fixed):**
```java
String incrementalSQL;
try (Scanner scanner = new Scanner(new File(config.incrementalSQLFile))) {
incrementalSQL = scanner.useDelimiter("\\Z").next();
}
```
The `Scanner` is now wrapped in a try-with-resources statement, guaranteeing
that `scanner.close()` is called as soon as the block exits — whether normally
or via exception.
### Why are the changes needed?
Fixes #18440. The leaked file handle can cause
`java.io.FileNotFoundException: Too many open files` errors in long-running
Hive incremental pull jobs, especially when `executeIncrementalSQL` is invoked
repeatedly.
### Does this PR introduce _any_ user-facing change?
No. The fix is purely internal resource-management; observable behavior
(reading the SQL file and validating its contents) is unchanged.
### How was this patch tested?
The fix follows the standard Java try-with-resources idiom for `Closeable`
resources. Existing unit tests for `HiveIncrementalPuller` continue to pass
unchanged.<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
