voonhous commented on code in PR #18036:
URL: https://github.com/apache/hudi/pull/18036#discussion_r3040072128
##########
hudi-spark-datasource/hudi-spark4.0.x/src/test/java/org/apache/hudi/io/storage/row/TestHoodieRowParquetWriteSupportVariant.java:
##########
@@ -155,9 +190,71 @@ public void testWriteShreddedVariant() throws IOException {
assertEquals(BINARY, valueField.asPrimitiveType().getPrimitiveTypeName());
assertEquals(OPTIONAL, valueField.getRepetition(), "Shredded variant value
must be OPTIONAL");
- // Verify typed_value is omitted (as implementation skips it)
boolean hasTypedValue = vGroup.getFields().stream().anyMatch(f ->
f.getName().equals("typed_value"));
- assertFalse(hasTypedValue, "typed_value field should be omitted in this
writer implementation");
+ assertTrue(hasTypedValue, "typed_value field should be omitted in this
writer implementation");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
