nsivabalan commented on a change in pull request #2497:
URL: https://github.com/apache/hudi/pull/2497#discussion_r566968882
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -328,38 +328,62 @@ public synchronized HoodieArchivedTimeline
getArchivedTimeline() {
*/
public static HoodieTableMetaClient initTableTypeWithBootstrap(Configuration
hadoopConf, String basePath, HoodieTableType tableType,
String
tableName, String archiveLogFolder, String payloadClassName,
- String
baseFileFormat, String bootstrapIndexClass,
+ String
baseFileFormat, String preCombineField, String bootstrapIndexClass,
String
bootstrapBasePath) throws IOException {
return initTableType(hadoopConf, basePath, tableType, tableName,
- archiveLogFolder, payloadClassName, null, baseFileFormat,
bootstrapIndexClass, bootstrapBasePath);
+ archiveLogFolder, payloadClassName, null,
+ baseFileFormat, preCombineField, bootstrapIndexClass, bootstrapBasePath);
+ }
+
+ public static HoodieTableMetaClient initTableType(Configuration hadoopConf,
String basePath, HoodieTableType tableType,
+ String tableName, String
archiveLogFolder, String payloadClassName,
+ String baseFileFormat,
String preCombineField) throws IOException {
+ return initTableType(hadoopConf, basePath, tableType, tableName,
+ archiveLogFolder, payloadClassName, null, baseFileFormat,
preCombineField,
+ null, null);
}
public static HoodieTableMetaClient initTableType(Configuration hadoopConf,
String basePath, HoodieTableType tableType,
String tableName, String
archiveLogFolder, String payloadClassName,
String baseFileFormat)
throws IOException {
return initTableType(hadoopConf, basePath, tableType, tableName,
- archiveLogFolder, payloadClassName, null, baseFileFormat, null, null);
+ archiveLogFolder, payloadClassName, null, baseFileFormat, null,
+ null, null);
}
/**
* Used primarily by tests, examples.
*/
+ public static HoodieTableMetaClient initTableType(Configuration hadoopConf,
String basePath, HoodieTableType tableType,
+ String tableName, String
payloadClassName, String preCombineField) throws IOException {
+ return initTableType(hadoopConf, basePath, tableType, tableName, null,
payloadClassName,
+ null, preCombineField);
+ }
+
public static HoodieTableMetaClient initTableType(Configuration hadoopConf,
String basePath, HoodieTableType tableType,
String tableName, String
payloadClassName) throws IOException {
return initTableType(hadoopConf, basePath, tableType, tableName, null,
payloadClassName,
- null, null, null, null);
+ null, (String) null);
+ }
+
+ public static HoodieTableMetaClient initTableType(Configuration hadoopConf,
String basePath, HoodieTableType tableType,
Review comment:
@garyli1019 @vinothchandar : I am sure this would have been brought up
earlier too. Curious as to why we haven't exposed a builder for MetaClient
instantiation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
