danny0405 commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3055003037
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionPlanOperator.java:
##########
@@ -109,10 +97,7 @@ public void processElement(StreamRecord<RowData>
streamRecord) {
public void notifyCheckpointComplete(long checkpointId) {
// comment out: do we really need the timeout rollback ?
// CompactionUtil.rollbackEarliestCompaction(table, conf);
- // schedule data table compaction if enabled
- this.compactionPlanHandler.ifPresent(handler ->
handler.collectCompactionOperations(checkpointId, compactionMetrics, output));
- // Also schedule metadata table compaction if enabled
- this.mdtCompactionPlanHandler.ifPresent(handler ->
handler.collectCompactionOperations(checkpointId, compactionMetrics, output));
+ this.compactionPlanHandler.collectCompactionOperations(checkpointId,
compactionMetrics, output);
Review Comment:
The metrics is updated from both metadata table and data table, which is
incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
