pengzhiwei2018 commented on a change in pull request #2283:
URL: https://github.com/apache/hudi/pull/2283#discussion_r567252446
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
##########
@@ -249,6 +255,54 @@ public void testBasicSync(boolean useJdbc, boolean
useSchemaFromCommitMetadata)
"The last commit that was sycned should be 100");
}
+ @ParameterizedTest
+ @MethodSource({"useJdbcAndSchemaFromCommitMetadata"})
+ public void testSyncWithProperties(boolean useJdbc, boolean
useSchemaFromCommitMetadata) throws Exception {
Review comment:
Thanks @nsivabalan for these nice suggestions, I will spend some time
to process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
