shangxinli commented on code in PR #18405:
URL: https://github.com/apache/hudi/pull/18405#discussion_r3052989819
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkValidatorUtils.java:
##########
@@ -84,6 +84,22 @@ public static void runValidators(HoodieWriteConfig config,
Dataset<Row> beforeState = getRecordsFromCommittedFiles(sqlContext,
partitionsModified, table, afterState.schema());
Stream<SparkPreCommitValidator> validators =
Arrays.stream(config.getPreCommitValidators().split(","))
+ .map(String::trim)
+ .filter(s -> !s.isEmpty())
+ .filter(validatorClass -> {
Review Comment:
The WARN log in `SparkValidatorUtils` already covers the case where a
non-`SparkPreCommitValidator` is listed there. With this PR we've now added the
symmetric guard on the HoodieStreamer side too, so both paths emit WARN and
skip cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
