hotienvu commented on a change in pull request #2210:
URL: https://github.com/apache/hudi/pull/2210#discussion_r567403920
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/CsvDFSSource.java
##########
@@ -125,4 +134,12 @@ public CsvDFSSource(TypedProperties props,
return Option.empty();
}
}
+
+ @Override
Review comment:
Agreed this is not desirable. However it is quite tricky since the
current Source base classes are primarily based on the input format (Row vs
String vs Avro) instead of the actual source (DFS vs Kafka, etc). Same problem
with the repeated pathSelector for each DFS Sources. Some refactoring may be
required in order to abstract this cleanly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
