nsivabalan commented on a change in pull request #2427:
URL: https://github.com/apache/hudi/pull/2427#discussion_r567428646
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileWriter.java
##########
@@ -121,17 +121,10 @@ public void writeAvro(String recordKey, IndexedRecord
object) throws IOException
if (hfileConfig.useBloomFilter()) {
hfileConfig.getBloomFilter().add(recordKey);
- if (minRecordKey != null) {
- minRecordKey = minRecordKey.compareTo(recordKey) <= 0 ? minRecordKey :
recordKey;
- } else {
+ if (minRecordKey == null) {
Review comment:
@yui2010 : I synced up with Vinoth on this. He is fine with your
optimization. If there are any pending comments to be addressed, can you please
address and let me know once the patch is ready to be reviewed again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
