yihua commented on code in PR #18463:
URL: https://github.com/apache/hudi/pull/18463#discussion_r3061791535
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java:
##########
@@ -183,9 +183,12 @@ private void executeIncrementalSQL(String tempDbTable,
String tempDbTablePath, S
String storedAsClause = getStoredAsClause();
incrementalPullSQLTemplate.add("storedAsClause", storedAsClause);
- String incrementalSQL = new Scanner(new
File(config.incrementalSQLFile)).useDelimiter("\\Z").next();
+ String incrementalSQL;
+ try (Scanner sqlScanner = new Scanner(new
File(config.incrementalSQLFile))) {
+ incrementalSQL = sqlScanner.useDelimiter("\\Z").next();
+ }
if (!incrementalSQL.contains(config.sourceDb + "." + config.sourceTable)) {
- LOG.error("Incremental SQL does not have " + config.sourceDb + "." +
config.sourceTable
+ LOG.error("Incremental SQL does not have " + config.sourceDb + "." +
config.sourceTable
Review Comment:
🤖 The log message now reads `"does not have"` (two spaces). The previous
review confirmed this message had been corrected — it looks like that fix was
accidentally reverted and a new typo introduced. Could you restore the
single-space version?
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.</i></sub>
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HiveIncrementalPuller.java:
##########
@@ -126,12 +126,12 @@ private void validateConfig(Config config) {
}
}
- public void saveDelta() throws IOException {
+ public void saveDelta() throws IOException {
Review Comment:
🤖 This new diff drops the semicolon from `Statement stmt = null` and removes
the opening brace from `try`, both of which are compilation errors. The file
won't build in this state — could you double-check what was committed here?
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
