nsivabalan commented on code in PR #18295:
URL: https://github.com/apache/hudi/pull/18295#discussion_r3066998423
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java:
##########
@@ -241,6 +248,16 @@ public class HoodieLockConfig extends HoodieConfig {
@Deprecated
public static final String LOCK_PROVIDER_CLASS_PROP =
LOCK_PROVIDER_CLASS_NAME.key();
+ // Lock provider class names from modules not directly accessible in
hudi-client-common.
Review Comment:
I synced up w/ @yihua on this and generally we feel, adding a new public api
to write client will confuse users and we got to be very thorough in adding any
such public apis.
my recommendation is to take it up as a follow up. Consider different locks
for data table and mdt table or list down all possible approaches, go over pros
and cons and then add standalone tool for MDT table services if need be or take
the write client approach we feel we have compelling reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
