voonhous commented on code in PR #18488:
URL: https://github.com/apache/hudi/pull/18488#discussion_r3067731046
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestCreateTable.scala:
##########
@@ -2120,4 +2120,171 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
assertTrue(blobPathField.dataType.isInstanceOf[StringType])
}
}
+
+ test("test create table with VECTOR column") {
Review Comment:
Uhm, no point adding those now. Create a ticket and address it later.
This reads as scope creep/out of scope to me. I add this and reviewers will
just keep stacking ontop of this to ask me to consider xyz, when in fact, this
is not the scope.
If we do not support this grammar, now, let's just not support it.
I'm open to it being I'm a separate PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
