prashantwason commented on a change in pull request #2496:
URL: https://github.com/apache/hudi/pull/2496#discussion_r568062733
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1193,6 +1218,21 @@ public Builder withMergeAllowDuplicateOnInserts(boolean
routeInsertsToNewFiles)
return this;
}
+ public Builder withFileIOBufferEnabled(boolean enabled) {
+ props.setProperty(FILE_IO_BUFFER_ENABLED, String.valueOf(enabled));
+ return this;
+ }
+
+ public Builder withFileIOBufferMinSize(int sizeInBytes) {
Review comment:
Buffering is a verb. So when asking "is buffering enabled" I have used
the ing form. The size of the buffer is in bytes. So for getting the size of
the buffer, I have used "buffer".
Buffering is enabled/disabled. Buffering does not have a size. Buffer has a
size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
